all files formatted successfully#1788
Closed
karanupd12 wants to merge 1 commit intoTheAlgorithms:masterfrom
karanupd12:add-prefix-sum-algorithm
Closed
all files formatted successfully#1788karanupd12 wants to merge 1 commit intoTheAlgorithms:masterfrom karanupd12:add-prefix-sum-algorithm
karanupd12 wants to merge 1 commit intoTheAlgorithms:masterfrom
karanupd12:add-prefix-sum-algorithm
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
+ Coverage 85.87% 85.90% +0.02%
==========================================
Files 377 378 +1
Lines 19720 19757 +37
Branches 3005 3016 +11
==========================================
+ Hits 16935 16972 +37
Misses 2785 2785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I noticed there's a spelling error in an existing file (not related to my changes), but I've kept my PR focused solely on the BasicPrefixSum implementation to avoid scope creep. My changes are limited to:
The spelling error appears to be in a pre-existing file and is unrelated to the prefix sum algorithm implementation. I can create a separate issue/PR to address that spelling error if needed, but wanted to keep this contribution focused on the specific issue #1783. Thanks for reviewing! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1783
Description
Added BasicPrefixSum algorithm implementation with comprehensive test suite.
Changes
PrefixSum/BasicPrefixSum.jswith input validationPrefixSum/BasicPrefixSum.test.jswith edge case coverageTesting
Implementation includes tests for:
Code Quality